From: Oleg Broytman <phd@phdru.name>
Date: Sat, 26 Dec 2015 19:08:04 +0000 (+0300)
Subject: Make parse_glst_file generator
X-Git-Tag: 0.0.4~62
X-Git-Url: https://git.phdru.name/?a=commitdiff_plain;h=7e963f12cfc58f88b35fb8071c63f9e47b2a51f7;hp=c80b45285f662162061a614a3072a34c16415871;p=m_librarian.git

Make parse_glst_file generator

Yield immediately instead of appending to a list.
---

diff --git a/m_librarian/glst.py b/m_librarian/glst.py
index b943813..2de36c3 100755
--- a/m_librarian/glst.py
+++ b/m_librarian/glst.py
@@ -10,7 +10,6 @@ from .db import Genre
 
 def parse_glst_file(glst_filename):
     glst_file = codecs.open(glst_filename, 'r', 'utf-8')
-    genre_list = []
     try:
         for line in glst_file:
             line = line.strip()
@@ -23,10 +22,9 @@ def parse_glst_file(glst_filename):
                 name, title = parts[1].split(';', 1)
             except (IndexError, ValueError):
                 continue
-            genre_list.append((name, title))
+            yield name, title
     finally:
         glst_file.close()
-    return genre_list
 
 
 def import_glst_file(glst_filename):