]> git.phdru.name Git - m_librarian.git/commitdiff
Make parse_glst_file generator
authorOleg Broytman <phd@phdru.name>
Sat, 26 Dec 2015 19:08:04 +0000 (22:08 +0300)
committerOleg Broytman <phd@phdru.name>
Sat, 26 Dec 2015 19:08:04 +0000 (22:08 +0300)
Yield immediately instead of appending to a list.

m_librarian/glst.py

index b94381377e35072e98817665b18042cc2ac9c55a..2de36c3a92180b7abaf1b7b76079e51938e93c06 100755 (executable)
@@ -10,7 +10,6 @@ from .db import Genre
 
 def parse_glst_file(glst_filename):
     glst_file = codecs.open(glst_filename, 'r', 'utf-8')
-    genre_list = []
     try:
         for line in glst_file:
             line = line.strip()
@@ -23,10 +22,9 @@ def parse_glst_file(glst_filename):
                 name, title = parts[1].split(';', 1)
             except (IndexError, ValueError):
                 continue
-            genre_list.append((name, title))
+            yield name, title
     finally:
         glst_file.close()
-    return genre_list
 
 
 def import_glst_file(glst_filename):