From: Oleg Broytman <phd@phdru.name>
Date: Mon, 6 Jun 2016 19:07:40 +0000 (+0300)
Subject: Refactor author.filename
X-Git-Tag: 0.0.11~2
X-Git-Url: https://git.phdru.name/?a=commitdiff_plain;h=868f9fd045fa1b4aecc328f818017ecbc91533c4;hp=b0c1d9a111696fd1f4b8d6d79e472047d53c8957;p=m_librarian.git

Refactor author.filename
---

diff --git a/m_librarian/db.py b/m_librarian/db.py
index 8786a46..e7eea99 100755
--- a/m_librarian/db.py
+++ b/m_librarian/db.py
@@ -20,6 +20,12 @@ class Author(SQLObject):
     books = RelatedJoin('Book', otherColumn='book_id',
                         intermediateTable='author_book',
                         createRelatedTable=False)
+
+    @property
+    def fullname(self):
+        fullnames = filter(None, (self.surname, self.name, self.misc_name))
+        return ' '.join(fullnames)
+
     full_name_idx = DatabaseIndex(surname, name, misc_name, unique=True)
     count_idx = DatabaseIndex(count)
 
diff --git a/scripts/ml-search.py b/scripts/ml-search.py
index b257084..0d995e5 100755
--- a/scripts/ml-search.py
+++ b/scripts/ml-search.py
@@ -60,9 +60,7 @@ def _search_authors(case_sensitive, search_type, args):
         return
     count = 0
     for author in authors:
-        names = filter(None, (author.surname, author.name, author.misc_name))
-        fullname = u' '.join(names)
-        print fullname.encode(default_encoding), \
+        print author.fullname.encode(default_encoding), \
             (u"(%s: %d)" % (_('books'), author.count))\
             .encode(default_encoding),
         if args.verbose >= 1:
@@ -158,10 +156,7 @@ def _search_books(case_sensitive, search_type, args):
         if args.verbose >= 1:
             print " ", _("Author(s)").encode(default_encoding), ":",
             for author in book.authors:
-                names = filter(None,
-                               (author.surname, author.name, author.misc_name))
-                fullname = u' '.join(names)
-                print fullname.encode(default_encoding),
+                print author.fullname.encode(default_encoding),
             print
             print " ", _("Genre(s)").encode(default_encoding), ":",
             for genre in book.genres: