From 2f22015c59cf7d74f8ebfdf025c1ec0503cf867f Mon Sep 17 00:00:00 2001 From: Oleg Broytman Date: Mon, 5 Aug 2019 17:55:45 +0300 Subject: [PATCH] .shellrc: Improve array processing Make `GIT_REMOTES` array instead of converting it from a string to array. --- .shellrc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.shellrc b/.shellrc index 9a484c1..3eeb621 100644 --- a/.shellrc +++ b/.shellrc @@ -225,14 +225,13 @@ if test -x /usr/bin/git >/dev/null 2>&1; then cdgitpath remote.$remote.url else - local GIT_REMOTES remote - GIT_REMOTES="" + local remote + local -a GIT_REMOTES=() for remote in `git remote`; do if git config --get remote.$remote.url | grep -q '^\(/\|\.\./\)'; then - GIT_REMOTES="$GIT_REMOTES $remote" + GIT_REMOTES+=($remote) fi done - GIT_REMOTES=($GIT_REMOTES) if [ ${#GIT_REMOTES[*]} -eq 1 ]; then remote=${GIT_REMOTES[0]} cdgitpath remote.$remote.url @@ -281,11 +280,11 @@ if test -x /usr/bin/git >/dev/null 2>&1; then echo "Usage: _list_remotes remote_regexp" >&2 return 1 fi - GIT_REMOTES="" + declare -ag GIT_REMOTES=() local remote for remote in `git remote`; do if git config --get remote.$remote.url | grep -q "$1"; then - GIT_REMOTES="$GIT_REMOTES $remote" + GIT_REMOTES+=($remote) fi done } -- 2.39.5