From 7e963f12cfc58f88b35fb8071c63f9e47b2a51f7 Mon Sep 17 00:00:00 2001 From: Oleg Broytman Date: Sat, 26 Dec 2015 22:08:04 +0300 Subject: [PATCH] Make parse_glst_file generator Yield immediately instead of appending to a list. --- m_librarian/glst.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/m_librarian/glst.py b/m_librarian/glst.py index b943813..2de36c3 100755 --- a/m_librarian/glst.py +++ b/m_librarian/glst.py @@ -10,7 +10,6 @@ from .db import Genre def parse_glst_file(glst_filename): glst_file = codecs.open(glst_filename, 'r', 'utf-8') - genre_list = [] try: for line in glst_file: line = line.strip() @@ -23,10 +22,9 @@ def parse_glst_file(glst_filename): name, title = parts[1].split(';', 1) except (IndexError, ValueError): continue - genre_list.append((name, title)) + yield name, title finally: glst_file.close() - return genre_list def import_glst_file(glst_filename): -- 2.39.5