From a1466ed36db55b032ce2d4f1ff57367487e21d57 Mon Sep 17 00:00:00 2001 From: Oleg Broytman Date: Sat, 29 Apr 2017 17:57:21 +0300 Subject: [PATCH] Use subprocess.call() instead of os.system() --- docs/news.rst | 2 ++ tests/test_remove_old_files.py | 17 +++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/docs/news.rst b/docs/news.rst index 8642710..7e9a9aa 100644 --- a/docs/news.rst +++ b/docs/news.rst @@ -6,6 +6,8 @@ Version 0.2.0 (2017-05-??) * Test at Travis and AppVeyor. +* Use subprocess.call() instead of os.system(). + 0.1.0 (2017-04-16) ------------------ diff --git a/tests/test_remove_old_files.py b/tests/test_remove_old_files.py index 87fc3e3..99c9034 100755 --- a/tests/test_remove_old_files.py +++ b/tests/test_remove_old_files.py @@ -2,6 +2,7 @@ import os import shutil +import subprocess import sys from tempfile import mkdtemp @@ -55,8 +56,8 @@ def test_remove_old_files(): create_files(['test1', 'test2']) assert_files_exist(['test1', 'test2']) os.utime('test2', (0, 0)) - assert os.system( - "%s %s --older 100 ." % (sys.executable, test_prog_path)) == 0 + assert subprocess.call( + [sys.executable, test_prog_path, "--older", "100", "."]) == 0 assert_files_exist('test1') assert_files_not_exist('test2') @@ -67,8 +68,8 @@ def test_recursive(): test4 = os.path.join('subdir', 'test4') assert_files_exist([test3, test4]) os.utime(test4, (0, 0)) - assert os.system( - "%s %s --older 100 ." % (sys.executable, test_prog_path)) == 0 + assert subprocess.call( + [sys.executable, test_prog_path, "--older", "100", "."]) == 0 assert_files_exist(test3) assert_files_not_exist(test4) @@ -80,10 +81,10 @@ def test_remove_empty_directory(): assert_files_exist([test3, test4]) os.utime(test3, (0, 0)) os.utime(test4, (0, 0)) - assert os.system( - "%s %s --older 100 ." % (sys.executable, test_prog_path)) == 0 + assert subprocess.call( + [sys.executable, test_prog_path, "--older", "100", "."]) == 0 assert_files_exist('subdir') assert_files_not_exist([test3, test4]) - assert os.system( - "%s %s -e --older 100 ." % (sys.executable, test_prog_path)) == 0 + assert subprocess.call( + [sys.executable, test_prog_path, "-e", "--older", "100", "."]) == 0 assert_files_not_exist('subdir') -- 2.39.5