From: Oleg Broytman <phd@phdru.name>
Date: Mon, 5 Aug 2019 14:55:45 +0000 (+0300)
Subject: .shellrc: Improve array processing
X-Git-Url: https://git.phdru.name/?p=dotfiles.git;a=commitdiff_plain;h=2f22015c59cf7d74f8ebfdf025c1ec0503cf867f

.shellrc: Improve array processing

Make `GIT_REMOTES` array instead of converting it
from a string to array.
---

diff --git a/.shellrc b/.shellrc
index 9a484c1..3eeb621 100644
--- a/.shellrc
+++ b/.shellrc
@@ -225,14 +225,13 @@ if test -x /usr/bin/git >/dev/null 2>&1; then
          cdgitpath remote.$remote.url
       else
 
-         local GIT_REMOTES remote
-         GIT_REMOTES=""
+         local remote
+         local -a GIT_REMOTES=()
          for remote in `git remote`; do
             if git config --get remote.$remote.url | grep -q '^\(/\|\.\./\)'; then
-               GIT_REMOTES="$GIT_REMOTES $remote"
+               GIT_REMOTES+=($remote)
             fi
          done
-         GIT_REMOTES=($GIT_REMOTES)
          if [ ${#GIT_REMOTES[*]} -eq 1 ]; then
             remote=${GIT_REMOTES[0]}
             cdgitpath remote.$remote.url
@@ -281,11 +280,11 @@ if test -x /usr/bin/git >/dev/null 2>&1; then
             echo "Usage: _list_remotes remote_regexp" >&2
             return 1
          fi
-         GIT_REMOTES=""
+         declare -ag GIT_REMOTES=()
          local remote
          for remote in `git remote`; do
             if git config --get remote.$remote.url | grep -q "$1"; then
-               GIT_REMOTES="$GIT_REMOTES $remote"
+               GIT_REMOTES+=($remote)
             fi
          done
       }