X-Git-Url: https://git.phdru.name/?p=extfs.d.git;a=blobdiff_plain;f=xml;h=5ed82db406ae9a061a733b046c0f050102adc9df;hp=15ef7117f65788269070259e166d9585ada87955;hb=7333a3485fd782d8f7b3850e88f649d75afd505d;hpb=71b9735e5da1c1685d95e99032799f637c8953fd

diff --git a/xml b/xml
index 15ef711..5ed82db 100755
--- a/xml
+++ b/xml
@@ -21,9 +21,12 @@ comments are represented as text files; attributes are shown in a file named
 deliberately ignore a small chance of newline characters in values); names and
 values are reencoded to the console encoding. Text nodes and comments are
 collected in a file named "text", stripped and reencoded. The filesystem is
-read-only. ElementTree-based implementation doesn't show namespaces as
-attributes; lxml.etree-based implementation shows namespaces as a separate file
-"namespaces"; every child tag includes its parent's namespaces.
+read-only.
+
+Implementation based on minidom doesn't understand namespaces, it just shows
+them among other attributes. ElementTree-based implementation doesn't show
+namespaces at all. Implementation based on lxml.etree shows namespaces in a
+separate file "namespaces"; every child tag includes its parent's namespaces.
 
 It is useful to have a top-down view on an XML structure but it's especially
 convenient to extract text values from tags. One can get, for example, a
@@ -34,13 +37,13 @@ The VFS was inspired by a FUSE xmlfs: https://github.com/halhen/xmlfs
 
 """
 
-__version__ = "0.5.0"
+__version__ = "0.5.1"
 __author__ = "Oleg Broytman <phd@phdru.name>"
 __copyright__ = "Copyright (C) 2013 PhiloSoft Design"
 __license__ = "GPL"
 
-default_implementation = None # Can be None for default choice,
-                              # 'lxml', 'elementtree' or 'minidom'
+default_implementation = None  # Can be None for default choice,
+                               # 'lxml', 'elementtree' or 'minidom'
 
 use_minidom = True
 use_elementtree = False
@@ -140,7 +143,7 @@ class MiniDOMXmlVfs(XmlVfs):
 
     def attrs2text(self, node):
         attrs = node.attributes
-        attrs = [attrs.item(i) for i in range (attrs.length)]
+        attrs = [attrs.item(i) for i in range(attrs.length)]
         return '\n'.join(["%s=%s" %
             (a.name.encode(default_encoding, "replace"),
             a.value.encode(default_encoding, "replace"))
@@ -167,7 +170,7 @@ class MiniDOMXmlVfs(XmlVfs):
             if element.localName:
                 n += 1
         if n:
-            width = int(math.log10(n))+1
+            width = int(math.log10(n)) + 1
             template = "%%0%dd" % width
         else:
             template = "%d"
@@ -213,7 +216,7 @@ if use_elementtree or use_lxml:
                 if text: text_accumulator.append(text)
             for element in node:
                 if not self.istag(element):
-                    text = u"<!--%s-->" % text
+                    text = u"<!--%s-->" % element.text
                     text_accumulator.append(text)
             if node.tail:
                 text = node.tail.strip()
@@ -237,26 +240,26 @@ if use_elementtree:
 
             class PIParser(ET.XMLTreeBuilder):
 
-               def __init__(self):
-                   ET.XMLTreeBuilder.__init__(self)
-                   # assumes ElementTree 1.2.X
-                   self._parser.CommentHandler = self.handle_comment
-                   self._parser.ProcessingInstructionHandler = self.handle_pi
-                   self._target.start("document", {})
-
-               def close(self):
-                   self._target.end("document")
-                   return ET.XMLTreeBuilder.close(self)
-
-               def handle_comment(self, data):
-                   self._target.start(ET.Comment, {})
-                   self._target.data(data)
-                   self._target.end(ET.Comment)
-
-               def handle_pi(self, target, data):
-                   self._target.start(ET.PI, {})
-                   self._target.data(target + " " + data)
-                   self._target.end(ET.PI)
+                def __init__(self):
+                    ET.XMLTreeBuilder.__init__(self)
+                    # assumes ElementTree 1.2.X
+                    self._parser.CommentHandler = self.handle_comment
+                    self._parser.ProcessingInstructionHandler = self.handle_pi
+                    self._target.start("document", {})
+
+                def close(self):
+                    self._target.end("document")
+                    return ET.XMLTreeBuilder.close(self)
+
+                def handle_comment(self, data):
+                    self._target.start(ET.Comment, {})
+                    self._target.data(data)
+                    self._target.end(ET.Comment)
+
+                def handle_pi(self, target, data):
+                    self._target.start(ET.PI, {})
+                    self._target.data(target + " " + data)
+                    self._target.end(ET.PI)
 
             self.document = ET.parse(sys.argv[2], PIParser())