Feat(Robots/bkmk_rrequests): Ignore all problems with certificates

[bookmarks_db.git] / Robots / bkmk_rrequests.py

diff --git a/Robots/bkmk_rrequests.py b/Robots/bkmk_rrequests.py
index 08fe09ebcd830725ebb54263a7d28f7b36d8e79d..4577b1608d4992816f8a7ac943c339ec61cca1ac 100644 (file)
--- a/Robots/bkmk_rrequests.py
+++ b/Robots/bkmk_rrequests.py
@@ -12,7 +12,10 @@ __all__ = ['robot_requests']
 
 
 from urllib.parse import urlsplit
+import warnings
 
+from requests.adapters import HTTPAdapter
+from requests.packages.urllib3.util.ssl_ import create_urllib3_context
 import requests
 import requests_ftp
 
@@ -50,16 +53,16 @@ class robot_requests(robot_base):
         else:
             error, r = request_get(url, headers, self.timeout, None)
             if error is not None:
-                self.log('   Error: %s' % error)
-                if self.proxy:
+                self.log('   Error          : %s' % error)
+                if self.proxy and error != '404 not_found':
                     self.log('   Retrying with the proxy...')
                     error, r = request_get(url, headers,
                                            self.timeout, self.proxy)
                     if error is None:
                         self.proxy_ok.add(url_host)
         if error is not None:
-            if self.proxy:
-                self.log('   Proxy error: %s' % error)
+            if self.proxy and error != '404 not_found':
+                self.log('   Proxy error    : %s' % error)
                 if url_host not in self.proxy_ok:
                     self.proxy_error.add(url_host)
             return error, None, None, None, None
@@ -71,16 +74,42 @@ class robot_requests(robot_base):
         return ''  # Alas, requests_ftp doesn't store welcome message
 
 
+# See https://lukasa.co.uk/2017/02/Configuring_TLS_With_Requests/
+
+class AllCiphersAdapter(HTTPAdapter):
+    """
+    A TransportAdapter that re-enables 3DES support in Requests.
+    """
+    def init_poolmanager(self, *args, **kwargs):
+        context = create_urllib3_context(cert_reqs=0,
+                                         ciphers='ALL:@SECLEVEL=1')
+        kwargs['ssl_context'] = context
+        return super(AllCiphersAdapter, self).init_poolmanager(*args, **kwargs)
+
+    def proxy_manager_for(self, *args, **kwargs):
+        context = create_urllib3_context(cert_reqs=0,
+                                         ciphers='ALL:@SECLEVEL=1')
+        kwargs['ssl_context'] = context
+        return super(AllCiphersAdapter, self).proxy_manager_for(
+            *args, **kwargs)
+
+
+warnings.filterwarnings('ignore', 'Unverified HTTPS request is being made')
+
+
 def request_get(url, headers, timeout, proxy):
     if proxy:
         proxies = {'http': proxy, 'https': proxy}
     else:
         proxies = None
 
+    s = requests.Session()
+    s.mount('https://', AllCiphersAdapter())
+
     try:
-        r = requests.Session().get(
-            url, headers=headers, timeout=timeout,
-            allow_redirects=False, proxies=proxies)
+        r = s.get(url, headers=headers, timeout=timeout,
+                  allow_redirects=False, proxies=proxies,
+                  verify=False)
     except requests.RequestException as e:
         return str(e), None
     else: