Log is always open.

[bookmarks_db.git] / Robots / bkmk_rsimple.py

diff --git a/Robots/bkmk_rsimple.py b/Robots/bkmk_rsimple.py
index 47c2c7b425addbab96b0a4173c442ad61693debe..2591588b9362743f44ade9bf5ca1dedce2f1b54a 100644 (file)
--- a/Robots/bkmk_rsimple.py
+++ b/Robots/bkmk_rsimple.py
@@ -5,7 +5,7 @@
 """
 
 
-import sys, os, string
+import sys, os
 import time, urllib
 from base64 import b64encode
 from urlparse import urljoin
@@ -61,14 +61,14 @@ urllib._urlopener.addheader('Referer', 'http://www.yahoo.com/')
 
 
 def get_error(msg):
-   if type(msg) == type(""):
+   if isinstance(msg, str):
       return msg
 
    else:
       s = []
       for i in msg:
-         s.append("'%s'" % string.join(string.split(str(i), "\n"), "\\n"))
-      return "(%s)" % string.join(s)
+         s.append("'%s'" % str(i).replace('\n', "\\n"))
+      return "(%s)" % ' '.join(s)
 
 
 urllib_ftpwrapper = urllib.ftpwrapper
@@ -78,7 +78,7 @@ class myftpwrapper(urllib_ftpwrapper):
    def __init__(self, user, passwd, host, port, dirs):
       urllib_ftpwrapper.__init__(self, user, passwd, host, port, dirs)
       global ftpcache_key
-      ftpcache_key = (user, host, port, string.join(dirs, '/'))
+      ftpcache_key = (user, host, port, tuple(dirs))
 
 urllib.ftpwrapper = myftpwrapper
 
@@ -150,10 +150,10 @@ class robot_simple(Robot):
                      content_type, charset = content_type.split(';')
                      content_type = content_type.strip()
                      charset = charset.split('=')[1].strip()
-                     if self.log: self.log("   HTTP charset   : %s" % charset)
+                     self.log("   HTTP charset   : %s" % charset)
                   except (ValueError, IndexError):
                      charset = None
-                     if self.log: self.log("   no charset in Content-Type header")
+                     self.log("   no charset in Content-Type header")
                   if content_type == "text/html":
                      parser = parse_html(fname, charset, self.log)
                      bookmark.real_title = parser.title
@@ -179,21 +179,21 @@ class robot_simple(Robot):
                      if not icon:
                         icon = "/favicon.ico"
                      icon = urljoin("%s://%s%s" % (url_type, url_host, url_path), icon)
-                     if self.log: self.log("   looking for icon at: %s" % icon)
+                     self.log("   looking for icon at: %s" % icon)
                      try:
                         for i in range(8):
                            try:
                               fname, headers = urllib.urlretrieve(icon)
                            except RedirectException, e:
                               icon = e.url
-                              if self.log: self.log("       redirect to : %s" % icon)
+                              self.log("       redirect to : %s" % icon)
                            else:
                               break
                         else:
                            raise IOError("Too many redirects")
                      except:
                         etype, emsg, tb = sys.exc_info()
-                        if self.log: self.log("   no icon        : %s %s" % (etype, emsg))
+                        self.log("   no icon        : %s %s" % (etype, emsg))
                         etype = None
                         emsg = None
                         tb = None
@@ -204,9 +204,9 @@ class robot_simple(Robot):
                            icon = icon_file.read()
                            icon_file.close()
                            bookmark.icon = "data:%s;base64,%s" % (content_type, b64encode(icon))
-                           if self.log: self.log("   got icon       : %s" % content_type)
+                           self.log("   got icon       : %s" % content_type)
                         else:
-                           if self.log: self.log("   no icon        : bad content type '%s'" % content_type)
+                           self.log("   no icon        : bad content type '%s'" % content_type)
                         os.remove(fname)
 
                except KeyError: