Do not even open non-image files; report the content type of a non-image file.

[bookmarks_db.git] / Robots / bkmk_rsimple.py

diff --git a/Robots/bkmk_rsimple.py b/Robots/bkmk_rsimple.py
index 58879b01bc3a76f33b059dd7e7f272bd8375900e..50db38843d0fa7cee6e4af5ed48ea51aee69861b 100644 (file)
--- a/Robots/bkmk_rsimple.py
+++ b/Robots/bkmk_rsimple.py
@@ -83,13 +83,16 @@ from bkmk_objects import Robot
 from parse_html import parse_html
 
 class robot_simple(Robot):
-   def check_url(self, bookmark, url_type, url_rest):
+   def check_url(self, bookmark):
       if not self.tempfname:
          self.tempfname = bookmark.tempfname
 
       try:
          try:
             self.start = int(time.time())
+            bookmark.icon = None
+
+            url_type, url_rest = urllib.splittype(bookmark.href)
             url_host, url_path = urllib.splithost(url_rest)
             url_path, url_tag  = urllib.splittag(url_path)
 
@@ -175,12 +178,15 @@ class robot_simple(Robot):
                         emsg = None
                         tb = None
                      else:
-                        icon_file = open(fname, "rb")
-                        icon = icon_file.read()
-                        icon_file.close()
-                        os.remove(fname)
                         content_type = headers["Content-Type"]
-                        bookmark.icon = "data:%s;base64,%s" % (content_type, b64encode(icon))
+                        if content_type.startswith("image/"):
+                           icon_file = open(fname, "rb")
+                           icon = icon_file.read()
+                           icon_file.close()
+                           bookmark.icon = "data:%s;base64,%s" % (content_type, b64encode(icon))
+                        else:
+                           if self.log: self.log("   no icon        : %s" % content_type)
+                        os.remove(fname)
 
                except KeyError:
                   pass