Remove Accept-Charset even in case of error

[bookmarks_db.git] / Robots / bkmk_rurllib.py

diff --git a/Robots/bkmk_rurllib.py b/Robots/bkmk_rurllib.py
index 2fdec0e917e465e34c61576445c577cb4b8a183a..ceaf67bd7218f5eb2b90203d2fdb0257d3b582e3 100644 (file)
--- a/Robots/bkmk_rurllib.py
+++ b/Robots/bkmk_rurllib.py
@@ -17,7 +17,7 @@ from Robots.bkmk_robot_base import robot_base, RedirectException, get_error
 
 
 class MyURLopener(urllib.URLopener):
-   # Error 301 -- relocated (temporarily)
+   # Error 301 -- relocated (permanently)
    def http_error_301(self, url, fp, errcode, errmsg, headers, data=None): 
       if headers.has_key('location'):
          newurl = headers['location']
@@ -27,11 +27,11 @@ class MyURLopener(urllib.URLopener):
          newurl = "Nowhere"
       raise RedirectException(errcode, newurl)
 
-   # Error 302 -- also relocated (permanently)
+   # Error 302 -- relocated (temporarily)
    http_error_302 = http_error_301
-   # Error 303 -- also relocated (permanently)
+   # Error 303 -- relocated (see other)
    http_error_303 = http_error_301
-   # Error 307 -- also relocated (temporary)
+   # Error 307 -- relocated (temporarily)
    http_error_307 = http_error_301
 
    # Error 401 -- authentication required
@@ -81,9 +81,11 @@ class robot_urllib(robot_base):
 
          if accept_charset and bookmark.charset:
             urllib._urlopener.addheader('Accept-Charset', bookmark.charset)
-         fname, headers = urllib.urlretrieve(url)
-         if accept_charset and bookmark.charset:
-            del urllib._urlopener.addheaders[-1]
+         try:
+            fname, headers = urllib.urlretrieve(url)
+         finally:
+            if accept_charset and bookmark.charset:
+               del urllib._urlopener.addheaders[-1] # Remove Accept-Charset
 
          infile = open(fname, 'rb')
          content = infile.read()