Fix(Robot): Stop splitting and un-splitting URLs

[bookmarks_db.git] / parse_html / bkmk_parse_html.py

diff --git a/parse_html/bkmk_parse_html.py b/parse_html/bkmk_parse_html.py
index 85aeb88e4b63bef832f7f67871cb32e54e57a3de..922c745346ecfa8f8f9c2988ef94f85345dc167a 100644 (file)
--- a/parse_html/bkmk_parse_html.py
+++ b/parse_html/bkmk_parse_html.py
@@ -24,14 +24,6 @@ from compat import unicode, unichr
 DEFAULT_CHARSET = "cp1251"  # Stupid default for Russian Cyrillic
 parsers = []
 
-try:
-    from . import bkmk_ph_beautifulsoup4
-except ImportError:
-    pass
-else:
-    bkmk_ph_beautifulsoup4.DEFAULT_CHARSET = DEFAULT_CHARSET
-    parsers.append(bkmk_ph_beautifulsoup4.parse_html)
-
 try:
     from . import bkmk_ph_beautifulsoup
 except ImportError:
@@ -41,33 +33,26 @@ else:
     parsers.append(bkmk_ph_beautifulsoup.parse_html)
 
 try:
-    from . import bkmk_ph_html5
+    from . import bkmk_ph_beautifulsoup4
 except ImportError:
     pass
 else:
-    parsers.append(bkmk_ph_html5.parse_html)
+    bkmk_ph_beautifulsoup4.DEFAULT_CHARSET = DEFAULT_CHARSET
+    parsers.append(bkmk_ph_beautifulsoup4.parse_html)
 
 try:
-    from . import bkmk_ph_lxml
+    from . import bkmk_ph_htmlparser
 except ImportError:
     pass
 else:
-    parsers.append(bkmk_ph_lxml.parse_html)
+    parsers.append(bkmk_ph_htmlparser.parse_html)
 
 try:
-    from . import bkmk_ph_htmlparser
+    from . import bkmk_ph_lxml
 except ImportError:
     pass
 else:
-    parsers.append(bkmk_ph_htmlparser.parse_html)
-
-# ElementTidy often segfaults
-# try:
-#     from . import bkmk_ph_etreetidy
-# except ImportError:
-#     pass
-# else:
-#     parsers.append(bkmk_ph_etreetidy.parse_html)
+    parsers.append(bkmk_ph_lxml.parse_html)
 
 universal_charset = "utf-8"
 entity_re = re.compile("(&\\w+;)")
@@ -101,7 +86,7 @@ BKMK_DEBUG_HTML_PARSERS = os.environ.get("BKMK_DEBUG_HTML_PARSERS")
 
 
 def parse_html(html_text, charset=None, log=None):
-    if not parsers:
+    if not html_text or not parsers:
         return None
 
     if charset:
@@ -168,7 +153,7 @@ def parse_html(html_text, charset=None, log=None):
     #            parser.charset = 'ascii'
 
     converted_title = title = parser.title
-    if title and (not parser.charset):
+    if title and isinstance(title, bytes) and (not parser.charset):
         try:
             title.decode("ascii")
         except UnicodeDecodeError:
@@ -226,7 +211,7 @@ def parse_html(html_text, charset=None, log=None):
 
 
 def parse_filename(filename, charset=None, log=None):
-    fp = open(filename, 'rt')
+    fp = open(filename, 'rt', encoding=charset)
     try:
         parser = parse_html(fp.read(), charset=charset, log=log)
     finally: