Refactoring: add mk_search_conditions

[m_librarian.git] / m_librarian / search.py

diff --git a/m_librarian/search.py b/m_librarian/search.py
index 10cfc2880b629f1e1da081cd1cbfff26612a93da..300e2a639b4bcfdcb62672a723e8875c3ce166bd 100644 (file)
--- a/m_librarian/search.py
+++ b/m_librarian/search.py
@@ -1,5 +1,6 @@
 
 __all__ = [
+    'mk_search_conditions',
     'search_authors', 'search_books', 'search_extensions',
     'search_genres', 'search_languages',
 ]
@@ -8,63 +9,69 @@ from sqlobject.sqlbuilder import AND, func
 from .db import Author, Book, Extension, Genre, Language
 
 
-def _search_exact(table, case_sensitive, values):
-    expressions = []
+def _mk_search_conditions_with_operator(table, case_sensitive, comparison_op,
+                                        values, expressions):
+    _expressions = []
     if case_sensitive:
         for column, value in values.items():
-            expressions.append(getattr(table.q, column) == value)
+            _expressions.append(
+                getattr(getattr(table.q, column), comparison_op)(value))
+        for expr, value in expressions:
+            _expressions.append(
+                getattr(expr, comparison_op)(value))
     else:
         for column, value in values.items():
-            expressions.append(
-                func.lower(getattr(table.q, column)) == value.lower())
-    return AND(*expressions)
+            _expressions.append(
+                getattr(func.lower(
+                    getattr(table.q, column)), comparison_op)(value.lower()))
+        for expr, value in expressions:
+            _expressions.append(
+                getattr(func.lower(expr), comparison_op)(value.lower()))
+    return _expressions
 
 
-def _search_start(table, case_sensitive, values):
-    expressions = []
-    if case_sensitive:
-        for column, value in values.items():
-            expressions.append(getattr(table.q, column).startswith(value))
-    else:
-        for column, value in values.items():
-            expressions.append(
-                func.lower(getattr(table.q, column)).startswith(value.lower()))
-    return AND(*expressions)
+_search_conditions_dict = {
+    'start': 'startswith',
+    'substring': 'contains',
+    'full': '__eq__',
+}
 
 
-def _search_substring(table, case_sensitive, values):
-    expressions = []
-    if case_sensitive:
-        for column, value in values.items():
-            expressions.append(getattr(table.q, column).contains(value))
-    else:
-        for column, value in values.items():
-            expressions.append(
-                func.lower(getattr(table.q, column)).contains(value.lower()))
-    return AND(*expressions)
+def mk_search_conditions(table, search_type, case_sensitive, values,
+                         expressions):
+    return _mk_search_conditions_with_operator(
+        table, case_sensitive, _search_conditions_dict[search_type],
+        values, expressions)
 
 
-def _search(table, search_type, case_sensitive, values):
-    _search_f = globals()['_search_%s' % search_type]
-    conditions = _search_f(table, case_sensitive, values)
-    return table.select(conditions)
+def _search(table, search_type, case_sensitive, values,
+            expressions, orderBy=None):
+    conditions = mk_search_conditions(
+        table, search_type, case_sensitive, values, expressions)
+    return table.select(AND(*conditions), orderBy=orderBy)
 
 
-def search_authors(search_type, case_sensitive, values):
-    return _search(Author, search_type, case_sensitive, values)
+def search_authors(search_type, case_sensitive, values,
+                   expressions, orderBy=None):
+    return _search(Author, search_type, case_sensitive, values,
+                   expressions, orderBy)
 
 
-def search_books(search_type, case_sensitive, values):
-    return _search(Book, search_type, case_sensitive, values)
+def search_books(search_type, case_sensitive, values, orderBy=None):
+    return _search(Book, search_type, case_sensitive, values,
+                   [], orderBy)
 
 
-def search_extensions(search_type, case_sensitive, values):
-    return _search(Extension, search_type, case_sensitive, values)
+def search_extensions(search_type, case_sensitive, values, orderBy=None):
+    return _search(Extension, search_type, case_sensitive, values,
+                   [], orderBy)
 
 
-def search_genres(search_type, case_sensitive, values):
-    return _search(Genre, search_type, case_sensitive, values)
+def search_genres(search_type, case_sensitive, values, orderBy=None):
+    return _search(Genre, search_type, case_sensitive, values,
+                   [], orderBy)
 
 
-def search_languages(search_type, case_sensitive, values):
-    return _search(Language, search_type, case_sensitive, values)
+def search_languages(search_type, case_sensitive, values, orderBy=None):
+    return _search(Language, search_type, case_sensitive, values,
+                   [], orderBy)